-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
UMD is broken #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@Hypercubed thank you so much for bringing this up. I was about to use https://github.com/webpro/versionify to add the package.json version on the exported object, but got scared off by webpro/versionify#11 so I decided to come up with a my own ad hoc routine. Can you recommend an other way of adding the version on the bundle's exported object? |
Sorry, I can't think of an easy way off the top of my head. I usually don't include version numbers in dist files. Plus doesn't this introduce an inconsistency between the CommonJS version and the dist version? |
- appending `Plotly.version` is the bundle break UMD more info: #14
I can confirm that UMD in the fix-umd branch (after |
The browserify generated UMD files are broken by
appendVersion
in your bundle task. For CommonJS loading systemsPlotly
in the last line ofplotly.js
andplotly.min.js
(Plotly.version='1.0.0';
) is undefined.P.S. Great work! Thanks for making this open source.
The text was updated successfully, but these errors were encountered: