-
Notifications
You must be signed in to change notification settings - Fork 633
Fix/build #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think this is ready to merge @chriddyp @cldougl, but I'll wait for +1 from someone since these are fairly drastic changes. It's worth noting that You can ignore diffs from the jitter tests above (they're showing up because they use random data -- I still need to fix that). The rest of the diffs look good to me (we don't need a filename for local plots and before we were incorrectly including an additional layout). |
This all looks good to me (+1 for defaulting to |
Detected 3 differences -> http://cpsievert.github.io/plotly-test-table/4d27335/jitter-basic |
This would require a major version bump (2.1) since we're changing the default for inheriting properties.
Let me know what you think @chriddyp @cldougl