Skip to content

Support renderValue within iframe #1435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Support renderValue within iframe #1435

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions inst/htmlwidgets/plotly.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,11 @@ HTMLWidgets.widget({
x.config.modeBarButtonsToRemove.push("sendDataToCloud");
}

// if the object was passed in from another window, plotly will falsely think it isn't a "plain object"
// to get around this, we do a deep clone of the object
if (inIframe() && !isPlainObject(x))
x = $.extend(true, {}, x)

// if no plot exists yet, create one with a particular configuration
if (!instance.plotly) {

Expand Down Expand Up @@ -832,6 +837,10 @@ function isPlainObject(obj) {
);
}

function inIframe() {
return window && window.self !== window.top;
}

function subsetArrayAttrs(obj, indices) {
var newObj = {};
Object.keys(obj).forEach(function(k) {
Expand Down