Skip to content

chore(deps): update angular packages to v20 (major) - abandoned #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions demo/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,16 @@
},
"private": true,
"dependencies": {
"@angular/animations": "^19.1.5",
"@angular/common": "^19.1.5",
"@angular/compiler": "^19.1.5",
"@angular/core": "^19.1.5",
"@angular/forms": "^19.1.5",
"@angular/platform-browser": "^19.1.5",
"@angular/platform-browser-dynamic": "^19.1.5",
"@angular/platform-server": "^19.1.5",
"@angular/router": "^19.1.5",
"@angular/ssr": "^19.1.6",
"@angular/animations": "^20.0.0-next",
"@angular/common": "^20.0.0-next",
"@angular/compiler": "^20.0.0-next",
"@angular/core": "^20.0.0-next",
"@angular/forms": "^20.0.0-next",
"@angular/platform-browser": "^20.0.0-next",
"@angular/platform-browser-dynamic": "^20.0.0-next",
"@angular/platform-server": "^20.0.0-next",
"@angular/router": "^20.0.0-next",
"@angular/ssr": "^20.0.0-next",
"@netlify/angular-runtime": "file:..",
"@netlify/edge-functions": "^2.11.1",
"express": "^4.21.0",
Expand All @@ -29,9 +29,9 @@
"zone.js": "~0.15.0"
},
"devDependencies": {
"@angular-devkit/build-angular": "^19.1.6",
"@angular/cli": "^19.1.6",
"@angular/compiler-cli": "^19.1.5",
"@angular-devkit/build-angular": "^20.0.0-next",
"@angular/cli": "^20.0.0-next",
"@angular/compiler-cli": "^20.0.0-next",
"@types/express": "^4.17.21",
"@types/jasmine": "~5.1.0",
"@types/node": "^18.19.13",
Expand Down
33 changes: 27 additions & 6 deletions renovate.json5
Original file line number Diff line number Diff line change
Expand Up @@ -2,23 +2,24 @@
$schema: 'https://docs.renovatebot.com/renovate-schema.json',
extends: ['github>netlify/renovate-config:default'],
ignorePresets: [':prHourlyLimit2'],
prHourlyLimit: 0,
semanticCommits: true,
// The config we're extending ignores test dirs, but we want to bump some fixture deps
ignorePaths: ['**/node_modules/**'],
packageRules: [
// Since we've enabled Renovate (see above) for fixture sites, adjust the config for these.
// Since we've enabled Renovate (see above) for demo and fixture sites, adjust the config for these.
{
matchFileNames: ['tests/**/fixtures/**/package.json'],
matchFileNames: ['tests/**/fixtures/**/package.json', 'demo/package.json'],
// If a fixture requires a specific framework version, never bump it.
updatePinnedDependencies: false,
// Always use `chore:` (since these are test fixtures), to avoid no-op releases.
extends: [':semanticCommitTypeAll(chore)'],
},
{
description: 'Stable & unstable Angular bumps in test fixtures',
matchFileNames: ['tests/**/fixtures/**/package.json'],
// See https://docs.renovatebot.com/presets-monorepo/#monorepoangular.
matchSourceUrls: ['https://github.com/angular/angular'],
description: 'Stable & unstable Angular bumps in demo and test fixtures',
groupName: 'Angular packages',
matchFileNames: ['tests/**/fixtures/**/package.json', 'demo/package.json'],
matchPackageNames: ['@angular/**', 'zone.js', '@angular-devkit/**'],
// Override the schedule to get immediate PRs.
schedule: null,
// Apply a unique label so we can trigger additional workflows for these PRs.
Expand All @@ -31,5 +32,25 @@
// difficult (or impossible) to implement so we just disable it entirely.
automerge: false,
},
// Angular major version updates attempt to upgrade fixtures for Angular 17, 18 etc
// we never want to upgrade those, so we disable them in fixtures.
// Angular major versions are being released on 6 months schedule and we will need to handle them
// manually anyway (even if it's just creating test fixtures for them, without adjusting the runtime
// itself)
{
description: 'Disable angular major version upgrades in fixtures',
matchFileNames: ['tests/**/fixtures/**/package.json'],
matchPackageNames: ['@angular/**', '@angular-devkit/**'],
matchUpdateTypes: ['major'],
enabled: false,
},
// zone.js is in 0.x.y version range, so we also disable minor updates for those
{
description: 'Disable zone.js minor version upgrades in fixtures',
matchFileNames: ['tests/**/fixtures/**/package.json'],
matchPackageNames: ['zone.js'],
matchUpdateTypes: ['minor', 'major'],
enabled: false,
},
],
}
Loading