Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does a couple of things
$this->typeSpecifier->create
(I hope this closes False positive onAssert::upper()
always evaluates as true #85)nullOr*
assertions and replaces it withTypeCombinator::addNull
and calls to$this->typeSpecifier->create
. This should close Assert::nullOrStringNotEmpty() with string|null will always evaluate to true #33.SpecifiedTypes
a bit smarter by also looking at thesureNotTypes
. This retainsnon-empty-string
vianullOr*
andall*
betterall*
andnullOr*
almost everywhere, where it makes sensecontains
ornotWhitespaceOnly
)I know this is a big one, I'm happy to split it up or whatever makes sense. Some of the non-empty-string things seem to be a bit intertwined though.