Skip to content

Support uuid, ip, ipv4, ipv6, email and notWhitespaceOnly #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Support uuid, ip, ipv4, ipv6, email and notWhitespaceOnly #128

wants to merge 1 commit into from

Conversation

villfa
Copy link
Contributor

@villfa villfa commented Mar 10, 2022

I think we can safely say that a string passing one of those assertions is a non-empty string.

@ondrejmirtes
Copy link
Member

This was merged and reverted in the past (#89). No, changing the regression test to not report any errors isn't the right thing to do :)

Please open an issue (a feature request) instead to support these in the future. Thanks.

@herndlm
Copy link
Contributor

herndlm commented Mar 10, 2022

I have an idea about how to add that back, but it might also be dependant on something that Ondrej wants to fix soon. So just give it a bit more time please and I'd create a PR :)

@ondrejmirtes
Copy link
Member

Yeah, that's why I want an issue open about this so that we don't forget :)

@villfa
Copy link
Contributor Author

villfa commented Mar 10, 2022

Thanks for your answers!

By reading the linked issue I now understand what the test was for.

@herndlm do you want me to open the issue, or do you plan to it your self? I'm asking since you probably want to write down your ideas.

@villfa villfa deleted the feat/string branch March 10, 2022 16:13
@herndlm
Copy link
Contributor

herndlm commented Mar 10, 2022

Nah it's fine, please go ahead and open a very simple issue. There's not much to plan yet :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants