Skip to content

Separate rules from extension as in other phpstan extensions #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,14 @@ parameters:
container_xml_path: '%rootDir%/../../../var/cache/dev/srcApp_KernelDevDebugContainer.xml'
```

You have to provide a path to `srcDevDebugProjectContainer.xml` or similar xml file describing your container.
You have to provide a path to `srcApp_KernelDevDebugContainer.xml` or similar xml file describing your container.

To perform framework-specific checks, include also this file:

```
includes:
- vendor/phpstan/phpstan-symfony/rules.neon
```

## Constant hassers

Expand Down
3 changes: 2 additions & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
},
"phpstan": {
"includes": [
"extension.neon"
"extension.neon",
"rules.neon"
]
}
},
Expand Down
8 changes: 0 additions & 8 deletions extension.neon
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,6 @@ parameters:
constant_hassers: true
console_application_loader: null

rules:
- PHPStan\Rules\Symfony\ContainerInterfacePrivateServiceRule
- PHPStan\Rules\Symfony\ContainerInterfaceUnknownServiceRule
- PHPStan\Rules\Symfony\UndefinedArgumentRule
- PHPStan\Rules\Symfony\InvalidArgumentDefaultValueRule
- PHPStan\Rules\Symfony\UndefinedOptionRule
- PHPStan\Rules\Symfony\InvalidOptionDefaultValueRule

services:
# console resolver
-
Expand Down
7 changes: 7 additions & 0 deletions rules.neon
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
rules:
- PHPStan\Rules\Symfony\ContainerInterfacePrivateServiceRule
- PHPStan\Rules\Symfony\ContainerInterfaceUnknownServiceRule
- PHPStan\Rules\Symfony\UndefinedArgumentRule
- PHPStan\Rules\Symfony\InvalidArgumentDefaultValueRule
- PHPStan\Rules\Symfony\UndefinedOptionRule
- PHPStan\Rules\Symfony\InvalidOptionDefaultValueRule