Add dynamic return type to ResponseHeaderBag::getCookies #242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
requested changes
Feb 1, 2022
| if (isset($methodCall->getArgs()[0])) { | ||
| $argStrings = TypeUtils::getConstantStrings($scope->getType($methodCall->getArgs()[0]->value)); | ||
|
|
||
| if (count($argStrings) === 1 && $argStrings[0]->getValue() === ResponseHeaderBag::COOKIES_ARRAY) { |
There was a problem hiding this comment.
I worry that asking for runtime value of ResponseHeaderBag::COOKIES_ARRAY might fail here in some projects. Can you please check for ClassConstFetch and check that the user fetches the right constant here? Thanks.
There was a problem hiding this comment.
thanks for the guidance, not sure if this is the way you meant, let me know otherwise.
| $headerBag->setCookie(Cookie::create('cookie_name')); | ||
|
|
||
| assertType('array<int, Symfony\Component\HttpFoundation\Cookie>', $headerBag->getCookies()); | ||
| assertType('array<string, array<string, array<string, Symfony\Component\HttpFoundation\Cookie>>>', $headerBag->getCookies(ResponseHeaderBag::COOKIES_ARRAY)); |
There was a problem hiding this comment.
Also test the FLAT scenario.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to make
ResponseHeaderBag::getCookies()return dynamic type based on:https://github.com/symfony/symfony/blob/c112bf116f8d4eb2d44a70dffaed8d7f4f10e521/src/Symfony/Component/HttpFoundation/ResponseHeaderBag.php#L225
which when
arrayis passed, returns$this->cookieswhich contains:https://github.com/symfony/symfony/blob/c112bf116f8d4eb2d44a70dffaed8d7f4f10e521/src/Symfony/Component/HttpFoundation/ResponseHeaderBag.php#L184