Fix more TypeSpecifier issues regarding === #1058
Conversation
|
Just had a quick glance, but that looks definitely cleaner 👍 is now only a webmozart/assert edge case blocking? 🤦♂️ I don't fully understand why that fails, but it still fixes more than it breaks. Maybe because it can specify more now. Webmozart/assert might also be in need for another test that ensures that it errors with a variable that is already of type non-empty-string. |
|
Yeah, not entirely happy with the failures, I can probably write more failing tests based on that, will have to think about it a bit more :) For example I kept thinking about how to achieve what I needed in TypeCombinator to make the tests in 51e2df3 pass for 3 days, I was able to make the change this morning in 15 minutes :) So hopefully I'll be able to fix this too :) |
ondrejmirtes
force-pushed
the
typespecifier-fixes
branch
2 times, most recently
from
491d828 to
29392e5
Compare
ondrejmirtes
force-pushed
the
typespecifier-fixes
branch
from
29392e5 to
5978a39
Compare
|
This was so painful to come up with 😂 I hope it's green, otherwise I'm gonna bring a paint bucket and make it green by force. |
|
Oh, at least the new errors look useful. https://github.com/phpstan/phpstan-src/runs/5484096952?check_suite_focus=true |
|
And the Doctrine issues are just a coincidence, new version was released a few hours ago. |
No description provided.