Skip to content

Check on leading "[" removed as this check makes it very difficult to… #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ancpru
Copy link
Contributor

@ancpru ancpru commented Apr 30, 2019

… implement custom tags which might want to allow or require this character in the tag body.

A leading square bracket might not be necessary for standard tags, but StandardTagFactory allows registering or overriding of tag implementations which might want to accept this character right after the tag.

… implement custom tags which might want to allow or require this character in the tag body.
@mvriel
Copy link
Member

mvriel commented Dec 24, 2019

Do you have a use-case where such behaviour is desired? Without a concrete use-case I prefer to stick to the status quo as removing it may have inadvertent side effects

@jaapio
Copy link
Member

jaapio commented Feb 9, 2020

Thanks for your contribution. We had a better look at this issue and provided a suitable fix that works in more cases as intended.

This issue has been fixed in #200

@jaapio jaapio closed this Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants