Handle zero seed in Xoshiro256** #9250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
TimWolla
commented
Aug 4, 2022
TimWolla
commented
- Retry if the CSPRNG generates a zero seed.
- Throw if the user passes a zero seed.
zeriyoshi
approved these changes
Aug 5, 2022
|
Closes: #9249 |
cmb69
approved these changes
Aug 5, 2022
| zend_throw_exception(random_ce_Random_RandomException, "Failed to generate a random seed", 0); | ||
| RETURN_THROWS(); | ||
| } | ||
| } while (UNEXPECTED(state->state[0] == 0 && state->state[1] == 0 && state->state[2] == 0 && state->state[3] == 0)); |
There was a problem hiding this comment.
I'm not too happy about hard-coding the number of elements here, but can't come up with a more elegant solution, so I guess it's okay.
There was a problem hiding this comment.
Yeah, it also looked pretty verbose to me. But on the other hand it's not like the number of elements is ever going to change. Any kind of loop would make the code more complex for an extraordinarily uncommon case.
I thought about ORing all the elements together, but that would be less clear (interestingly gcc already optimizes the condition to (state->state[0] | state->state[1] | state->state[2] | state->state[3]) == 0).
- Retry if the CSPRNG generates a zero state. - Throw ValueError if the user passes a zero state. Fixes phpGH-9249
TimWolla
force-pushed
the
xoshiro256starstar-nul
branch
from
87312a0 to
26de776
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.