Skip to content

Replace php_stdint.h header with standard headers #8613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2022

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented May 23, 2022

Going to investigate if both <inttypes.h> and <stdint.h> need to be included in all cases.

@cmb69
Copy link
Member

cmb69 commented May 24, 2022

I think that inttypes.h always includes stdint.h, so only including the former should be sufficient.

@Girgias Girgias force-pushed the drop-phpstdint-header branch from f611adc to 65757a6 Compare May 27, 2022 07:22
@Girgias Girgias force-pushed the drop-phpstdint-header branch from 65757a6 to cf544fd Compare May 27, 2022 07:57
@Girgias Girgias marked this pull request as ready for review May 27, 2022 08:56
@Girgias
Copy link
Member Author

Girgias commented May 27, 2022

Travis CI failure is unrelated (failed to send to QA)

@cmb69
Copy link
Member

cmb69 commented May 27, 2022

Travis CI failure is unrelated (failed to send to QA)

I think we should stop uploading the reports to qa.php.net; I don't think anybody has a look at these anyway.

@Girgias
Copy link
Member Author

Girgias commented May 27, 2022

Travis CI failure is unrelated (failed to send to QA)

I think we should stop uploading the reports to qa.php.net; I don't think anybody has a look at these anyway.

That's true

@Girgias Girgias merged commit d08451b into php:master May 29, 2022
@Girgias Girgias deleted the drop-phpstdint-header branch May 29, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants