Skip to content

Test snmp on Windows CI #8503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Test snmp on Windows CI #8503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6655c95
Test snmp on Windows CI
cmb69 May 6, 2022
aa51d4f
Kill snmpd.exe after executing the tests
cmb69 May 6, 2022
042b18a
Don't unnecessarily skip mb related tests
cmb69 May 6, 2022
65e184c
Mark failing tests as XFAIL on Windows
cmb69 May 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion appveyor/test_task.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,10 @@ if not exist "%PHP_BUILD_CACHE_ENCHANT_DICT_DIR%\en_US.aff" (
mkdir %LOCALAPPDATA%\enchant\hunspell
copy %PHP_BUILD_CACHE_ENCHANT_DICT_DIR%\* %LOCALAPPDATA%\enchant\hunspell

rem prepare for snmp
set MIBDIRS=%DEPS_DIR%\share\mibs
start %DEPS_DIR%\bin\snmpd.exe -C -c %APPVEYOR_BUILD_FOLDER%\ext\snmp\tests\snmpd.conf -Ln

set PHP_BUILD_DIR=%PHP_BUILD_OBJ_DIR%\Release
if "%THREAD_SAFE%" equ "1" set PHP_BUILD_DIR=%PHP_BUILD_DIR%_TS

Expand All @@ -101,7 +105,7 @@ rem work-around for some spawned PHP processes requiring OpenSSL
echo extension=php_openssl.dll >> %PHP_BUILD_DIR%\php.ini

rem remove ext dlls for which tests are not supported
for %%i in (imap ldap oci8_12c pdo_firebird pdo_oci snmp) do (
for %%i in (imap ldap oci8_12c pdo_firebird pdo_oci) do (
del %PHP_BUILD_DIR%\php_%%i.dll
)

Expand All @@ -116,6 +120,8 @@ nmake test TESTS="%OPCACHE_OPTS% -q --offline --show-diff --show-slow 1000 --set

set EXIT_CODE=%errorlevel%

taskkill /f /im snmpd.exe

appveyor PushArtifact %TEST_PHP_JUNIT%

if %EXIT_CODE% GEQ 1 (
Expand Down
1 change: 1 addition & 0 deletions ext/exif/tests/exif004.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
--TEST--
Check for exif_read_data, Unicode WinXP tags
--EXTENSIONS--
mbstring
exif
--SKIPIF--
<?php
Expand Down
1 change: 1 addition & 0 deletions ext/snmp/tests/bug64159.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ snmp
--SKIPIF--
<?php
require_once(__DIR__.'/skipif.inc');
if (PHP_OS_FAMILY === "Windows") die("xfail fails on Windows for unknown reasons");
?>
--ENV--
MIBS=noneXistent
Expand Down
1 change: 1 addition & 0 deletions ext/snmp/tests/snmp_getvalue.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ snmp
--SKIPIF--
<?php
require_once(__DIR__.'/skipif.inc');
if (PHP_OS_FAMILY === "Windows") die("xfail fails on Windows for unknown reasons");
?>
--FILE--
<?php
Expand Down
2 changes: 1 addition & 1 deletion ext/snmp/tests/snmpd.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ rocommunity public 127.0.0.1
rocommunity6 public ::1
rwcommunity private 127.0.0.1

Do not enable them - being set here they make appropriate OID switch into r/o
# Do not enable them - being set here they make appropriate OID switch into r/o
#syslocation "Somewhere in the world"
#syscontact "root"

Expand Down
4 changes: 3 additions & 1 deletion ext/standard/tests/file/windows_mb_path/bug54028.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
--TEST--
Bug #54028 Directory::read() cannot handle non-unicode chars properly
--EXTENSIONS--
mbstring
--SKIPIF--
<?php
include __DIR__ . DIRECTORY_SEPARATOR . "util.inc";

skip_if_not_win();
if (getenv("SKIP_SLOW_TESTS")) die("skip slow test");
skip_if_no_required_exts("mbstring");
skip_if_no_required_exts();

?>
--FILE--
Expand Down
4 changes: 3 additions & 1 deletion ext/standard/tests/file/windows_mb_path/test_cp1251_zend_multibyte_0.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
--TEST--
Test fopen() for reading CP1251 with zend.multibyte
--EXTENSIONS--
mbstring
--INI--
zend.multibyte=1
zend.script_encoding=cp1251
Expand All @@ -9,7 +11,7 @@ include __DIR__ . DIRECTORY_SEPARATOR . "util.inc";

skip_if_not_win();
if (getenv("SKIP_SLOW_TESTS")) die("skip slow test");
skip_if_no_required_exts("mbstring");
skip_if_no_required_exts();

?>
--CONFLICTS--
Expand Down
4 changes: 3 additions & 1 deletion ext/standard/tests/file/windows_mb_path/test_cp1251_zend_multibyte_1.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
--TEST--
Test mkdir/rmdir CP1251 with zend.multibyte
--EXTENSIONS--
mbstring
--INI--
zend.multibyte=1
zend.script_encoding=cp1251
Expand All @@ -9,7 +11,7 @@ include __DIR__ . DIRECTORY_SEPARATOR . "util.inc";

skip_if_not_win();
if (getenv("SKIP_SLOW_TESTS")) die("skip slow test");
skip_if_no_required_exts("mbstring");
skip_if_no_required_exts();

?>
--CONFLICTS--
Expand Down
4 changes: 3 additions & 1 deletion ext/standard/tests/file/windows_mb_path/test_cp1251_zend_multibyte_2.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
--TEST--
Test fopen() for write CP1251 with zend.multibyte
--EXTENSIONS--
mbstring
--INI--
zend.multibyte=1
zend.script_encoding=cp1251
Expand All @@ -9,7 +11,7 @@ include __DIR__ . DIRECTORY_SEPARATOR . "util.inc";

skip_if_not_win();
if (getenv("SKIP_SLOW_TESTS")) die("skip slow test");
skip_if_no_required_exts("mbstring");
skip_if_no_required_exts();

?>
--CONFLICTS--
Expand Down
4 changes: 3 additions & 1 deletion ext/standard/tests/file/windows_mb_path/test_long_path_0.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
--TEST--
Basic long path test
--EXTENSIONS--
mbstring
--SKIPIF--
<?php
include __DIR__ . DIRECTORY_SEPARATOR . "util.inc";

skip_if_not_win();
if (getenv("SKIP_SLOW_TESTS")) die("skip slow test");
skip_if_no_required_exts("mbstring");
skip_if_no_required_exts();

?>
--FILE--
Expand Down
4 changes: 3 additions & 1 deletion ext/standard/tests/file/windows_mb_path/test_long_path_2.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
--TEST--
Basic long path test with file I/O, multibyte path and realpath() check
--EXTENSIONS--
mbstring
--SKIPIF--
<?php
include __DIR__ . DIRECTORY_SEPARATOR . "util.inc";

skip_if_not_win();
if (getenv("SKIP_SLOW_TESTS")) die("skip slow test");
skip_if_no_required_exts("mbstring");
skip_if_no_required_exts();

?>
--FILE--
Expand Down