Skip to content

Fixed GH-8471: Segmentation fault when converting immutable and mutable DateTime instances created using reflection #8497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2022
Merged

Fixed GH-8471: Segmentation fault when converting immutable and mutable DateTime instances created using reflection #8497

merged 1 commit into from
May 5, 2022

Conversation

derickr
Copy link
Member

@derickr derickr commented May 5, 2022

No description provided.

@derickr derickr self-assigned this May 5, 2022
@derickr
Fixed phpGH-8471: Segmentation fault when converting immutable and mu…
92f8f19 
…table DateTime instances created using reflection
@derickr derickr force-pushed the GH-8471-segfault-with-createFrom branch from 362c96e to 92f8f19 Compare May 5, 2022 11:11
cmb69
cmb69 approved these changes May 5, 2022
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

The CI fails are due to #8478, so irrelevant here.

@derickr derickr merged commit dadc843 into php:PHP-8.0 May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 approved these changes

Assignees

@derickr derickr

Labels
Extension: date
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@derickr @cmb69