Skip to content

Fix GH-8170: --enable-debug configure option on Windows. #8171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix GH-8170: --enable-debug configure option on Windows. #8171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions win32/build/confutils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ function get_version_numbers()
}

configure_args = new Array();
configure_args_declared = {};
configure_subst = WScript.CreateObject("Scripting.Dictionary");

configure_hdr = WScript.CreateObject("Scripting.Dictionary");
Expand Down Expand Up @@ -228,6 +229,8 @@ function ConfigureArg(type, optname, helptext, defval)
this.arg = "--" + type + "-" + optname;
this.imparg = "--" + opptype + "-" + optname;
}
check_arg_uniqueness(this.arg);
check_arg_uniqueness(this.imparg);

this.optname = optname;
this.helptext = helptext;
Expand All @@ -237,6 +240,14 @@ function ConfigureArg(type, optname, helptext, defval)
this.argval = defval;
}

function check_arg_uniqueness(argname)
{
if (configure_args_declared[argname]) {
ERROR('Option ' + argname + ' is already declared.');
}
configure_args_declared[argname] = true;
}

function ARG_WITH(optname, helptext, defval)
{
configure_args[configure_args.length] = new ConfigureArg("with", optname, helptext, defval);
Expand Down
1 change: 0 additions & 1 deletion win32/build/phpize.js.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,6 @@ C.Write(file_get_contents(PHP_DIR + "/script/config.phpize.js"));
// Pull in code for the base detection
modules = file_get_contents(PHP_DIR + "/script/config.w32.phpize.in");

C.WriteLine("ARG_ENABLE('debug', 'Compile with debugging symbols', PHP_DEBUG);");
find_config_w32(".");

// Now generate contents of module based on MODULES, chasing dependencies
Expand Down