Add ASan support for MSVC #6964
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! |
|
I'm getting a lot of |
|
My first guess would be something to do with frame pointer elimination. Would passing |
At least not on x64 (tested; didn't test on x86). :( |
As of VS 16.9, there is native support for ASan in the MSVC toolchain. Although it is already possible to enable that by adding the respective option to `CFLAGS`, we make it available via the configure option `--enable-sanitizer` which is only used for clang builds on Windows so far. We also disable the manual inclusion of ASan headers, since these are available by default. We use the more general `__SANITIZE_ADDRESS__` for detection of ASan, to avoid a bogus warning, when `_setmaxstdio()` is called.
These are likely bogus, but that issue should be investigated when there is time; for now we just ignore it to make progress.
|
Note to self: test with Control Flow Guard disabled. |
|
Superseded by #15978. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of VS 16.9, there is native support for ASan in the MSVC toolchain.
Although it is already possible to enable that by adding the respective
option to
CFLAGS, we make it available via the configure option--enable-sanitizerwhich is only used for clang builds on Windows sofar.
We also disable the manual inclusion of ASan headers, since these are
available by default. We use the more general
__SANITIZE_ADDRESS__for detection of ASan, to avoid a bogus warning, when
_setmaxstdio()is called.
TODO: