Create separate lexbor extension #18538
Open
+357
−219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsismate
force-pushed
the
lexbor-extension
branch
from
c2b1e8d to
6a309fe
Compare
Girgias
reviewed
May 12, 2025
kocsismate
force-pushed
the
lexbor-extension
branch
2 times, most recently
from
9e9cb4c to
c228b4a
Compare
In preparation of php#14461 (https://wiki.php.net/rfc/url_parsing_api)
kocsismate
force-pushed
the
lexbor-extension
branch
from
c228b4a to
accf126
Compare
Co-authored-by: Gina Peter Banyard <[email protected]>
|
@cmb69 for Windows maybe? |
|
I haven't actually checked that (can do later if necessary), but I think we need to install the actual lexbor headers; cf. Line 12 in 4122daa I think that also needs to be done for POSIX systems, so phpize builds can work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation of #14461 (https://wiki.php.net/rfc/url_parsing_api)
Windows support is pretty much TBD, as I have no way to test it.