Skip to content

SplFileObject::fwrite $length param nullable #17242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 22, 2024
Merged

SplFileObject::fwrite $length param nullable #17242

merged 2 commits into from
Dec 22, 2024

Conversation

kamil-tekiela
Copy link
Member

Fixes #17228

Girgias
Girgias approved these changes Dec 22, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSTM.

Those arg num tricks are quite annoying in that they can lead to inconsistent behaviour.

@kamil-tekiela kamil-tekiela merged commit bf5e6c5 into php:master Dec 22, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

@kocsismate kocsismate Awaiting requested review from kocsismate kocsismate is a code owner

Assignees
No one assigned
Labels
Extension: spl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistency in SplFileObject::fwrite $length Parameter Behavior
2 participants
@kamil-tekiela @Girgias