ext/intl: TimeZone address todo to throw exceptions on error. #17215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
force-pushed
the
intl_timezone_todo
branch
from
52db0b4 to
00dca8f
Compare
cmb69
reviewed
Dec 23, 2024
| IntlDateFormatter::GREGORIAN, 'a')); | ||
| IntlDateFormatter::GREGORIAN, 'a'); | ||
| } catch (IntlException $e) { | ||
| echo PHP_EOL."Exception: " . $e->getMessage() . " in " . $e->getFile() . " on line " . $e->getLine() . PHP_EOL; |
There was a problem hiding this comment.
Might be sufficient to only printf $e->getMessage(), but that should be done consistently for this test case. Leaving as is, is also fine for me.
cmb69
reviewed
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.