Skip to content

Testing ASan for MSVC #15978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 26 commits into from
Closed

Testing ASan for MSVC #15978

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
7926092
Add ASan support for MSVC
cmb69 Sep 21, 2024
0c90d93
Enable ASAN for CI
cmb69 Sep 21, 2024
8526cef
Check for VSVERS >= 1929
cmb69 Sep 21, 2024
d4f1442
Run without JIT
cmb69 Sep 22, 2024
8dfff7d
Run tests with `--asan` options
cmb69 Sep 22, 2024
cda1ac7
Only run Zend tests for now
cmb69 Sep 22, 2024
04ffecb
Enable optimizations
cmb69 Sep 22, 2024
f9e8b4c
Only run Window CI for now
cmb69 Sep 22, 2024
692debf
Revert "Run without JIT"
cmb69 Sep 22, 2024
7f48875
Run all tests, but show progress
cmb69 Sep 22, 2024
8b801e3
Reapply "Run without JIT"
cmb69 Sep 22, 2024
e3a8332
Fix NDEBUG
cmb69 Nov 28, 2024
fd149e9
Disable CirclCI for now
cmb69 Nov 28, 2024
8cb7311
--enable-debug-pack
cmb69 Nov 28, 2024
572748e
Revert "Reapply "Run without JIT""
cmb69 Nov 28, 2024
0b3ed4c
Don't show progress
cmb69 Nov 28, 2024
944d603
Increase timeout
cmb69 Nov 28, 2024
eea8ec1
Stick with old flags for clang
cmb69 Nov 28, 2024
e6665ed
Fix help text
cmb69 Nov 28, 2024
6c7e3df
Avoid sanitizer/debug/debug-pack conflicts
cmb69 Nov 28, 2024
ec8fe7f
disable JIT again
cmb69 Nov 28, 2024
dee3e53
Increase timeout
cmb69 Nov 28, 2024
2b89440
Unblock tests under ASan on Windows
cmb69 Nov 29, 2024
771c467
Skip sapi_windows_set_ctrl_handler.phpt under ASan
cmb69 Nov 29, 2024
f15f135
Revert "disable JIT again"
cmb69 Nov 29, 2024
b703774
xfail STATUS_BAD_FUNCTION_TABLE tests
cmb69 Nov 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
188 changes: 0 additions & 188 deletions .circleci/config.yml
View file
Open in desktop

This file was deleted.

5 changes: 3 additions & 2 deletions .github/scripts/windows/build_task.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,12 +35,13 @@ set CFLAGS=/W1 /WX /w14013

cmd /c configure.bat ^
--enable-snapshot-build ^
--disable-debug-pack ^
--enable-debug-pack ^
--without-analyzer ^
--enable-object-out-dir=%PHP_BUILD_OBJ_DIR% ^
--with-php-build=%DEPS_DIR% ^
%ADD_CONF% ^
--disable-test-ini
--disable-test-ini ^
--enable-sanitizer
if %errorlevel% neq 0 exit /b 3

nmake /NOLOGO
Expand Down
2 changes: 1 addition & 1 deletion .github/scripts/windows/test_task.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ set TEST_PHPDBG_EXECUTABLE=%PHP_BUILD_DIR%\phpdbg.exe

mkdir c:\tests_tmp

nmake test TESTS="%OPCACHE_OPTS% -g FAIL,BORK,LEAK,XLEAK --no-progress -q --offline --show-diff --show-slow 1000 --set-timeout 120 --temp-source c:\tests_tmp --temp-target c:\tests_tmp %PARALLEL%"
nmake test TESTS="%OPCACHE_OPTS% -g FAIL,BORK,LEAK,XLEAK --asan --no-progress -q --offline --show-diff --show-slow 1000 --set-timeout 120 --temp-source c:\tests_tmp --temp-target c:\tests_tmp %PARALLEL%"

set EXIT_CODE=%errorlevel%

Expand Down
Loading