Remove native SSL support in phar extension #15574
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SSL support in phar extension is enabled when the PHP openssl extension is loaded, so there isn't any reason to have a separate native SSL support in phar extension. This removes the PHAR_HAVE_OPENSSL preprocessor macro from the PHP configuration header and the configure option --enable-phar-native-ssl on Windows. Also, the static libeay32 is not present in Windows OpenSSL builds anymore. The duplicate COMPILE_DL_PHAR compile definition is also removed as is already automatically defined in win32/build/confutils.js by the EXTENSION() function. Supersedes and closes phpGH-14578
petk
force-pushed
the
patch-remove-phar-native-ssl
branch
from
0c9c41e to
719da60
Compare
Girgias
approved these changes
Aug 25, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSL support in phar extension is enabled when the PHP openssl extension is loaded, so there isn't any reason to have a separate native SSL support in phar extension.
This removes the PHAR_HAVE_OPENSSL preprocessor macro from the PHP configuration header and the configure option --enable-phar-native-ssl on Windows. Also, the static libeay32 is not present in Windows OpenSSL builds anymore.
Supersedes and closes GH-14578