Autotools: Remove obsolete config.status invocations #15185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was once added to fix the bug https://bugs.php.net/13561 because the phpize and php-config scripts were located in the pear subdirectory and were installed only when --with-pear option was used. Then in the 20c4328 scripts were moved to scripts subdirectory with this mechanism used in the generated Makefile when running 'make install' command. Before the AC_CONFIG_FILES was introduced to Autoconf AC_OUTPUT once accepted arguments. This signature is obsolete in current Autoconf versions. The old obsolete config.status invocation: CONFIG_FILES=... ./config.status And the new invocation is (if used with AC_CONFIG_FILES in the code): ./config.status --file=... Instead, this simply removes the redundant phpize and php-config generation with the old obsolete config.status invocations as these files are always generated in the php-src build context.
petk
changed the title
petk
added a commit
to petk/php-src
that referenced
this pull request
Jul 31, 2024
This is a follow-up of phpGH-15177 (c96f08a) and phpGH-15185 The PHP_OUTPUT macro was introduced in the very early phase of the build system due to AC_OUTPUT handling issues in the old Autoconf versions before the AC_CONFIG_FILES, AC_CONFIG_COMMANDS etc were introduced with the AC_OUTPUT signature without arguments. The PHP_OUTPUT was also helping Makefile.in back then being properly generated based on whether all files were generated or only some (when using the obsolete CONFIG_FILES=... ./config.status invocation instead of the new ./config.status --file=...). Another issue is that PHP_OUTPUT can't be used by extensions when using phpize. This replaces the PHP_OUTPUT invocations with default AC_CONFIG_FILES. The obsolete "REDO_ALL" feature at the config.status invocation is also removed with a simpler unconditional generation. In phar extension the "ext/phar" is replaced with $ext_dir variable to be able to use phpize.
|
Merge coming up here. I'll recheck it again if I've missed anything... |
petk
added a commit
that referenced
this pull request
Aug 3, 2024
This is a follow-up of GH-15177 (c96f08a) and GH-15185 (9467ffb) The PHP_OUTPUT macro was introduced in the very early phase of the build system due to AC_OUTPUT handling issues in the old Autoconf versions before the AC_CONFIG_FILES, AC_CONFIG_COMMANDS etc were introduced with the AC_OUTPUT signature without arguments. The PHP_OUTPUT was also helping Makefile.in back then being properly generated based on whether all files were generated or only some (when using the obsolete CONFIG_FILES=... ./config.status invocation instead of the new ./config.status --file=...). Another issue is that PHP_OUTPUT can't be used by extensions when using phpize. This replaces the PHP_OUTPUT invocations with default AC_CONFIG_FILES. The obsolete "REDO_ALL" feature at the config.status invocation is also removed with a simpler unconditional generation. In phar extension the "ext/phar" is replaced with $ext_dir variable to be able to use phpize.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was once added to fix the bug https://bugs.php.net/13561 because the phpize and php-config scripts were located in the pear subdirectory and were installed only when --with-pear option was used. Then in the 20c4328 scripts were moved to scripts subdirectory with this mechanism used in the generated Makefile when running 'make install' command.
Before the AC_CONFIG_FILES was introduced to Autoconf AC_OUTPUT once accepted arguments. This signature is obsolete in current Autoconf versions.
The old obsolete config.status invocation:
CONFIG_FILES=... ./config.status
And the new invocation is (if used with AC_CONFIG_FILES in the code):
./config.status --file=...
Instead, this simply removes the redundant phpize and php-config generation with the old obsolete config.status invocations as these files are always generated in the php-src build context.