ext/pgsql: adding postgresql 17 new libpq wrapper call. #14571
Conversation
devnexen
force-pushed
the
pg_set_chunked_rows_mode
branch
2 times, most recently
from
9181959 to
ccb8fb8
Compare
| --SKIPIF-- | ||
| <?php | ||
| include("inc/skipif.inc"); | ||
| if (!function_exists("pg_set_chunked_rows_mode")) die("pg_set_chunked_rows_mode unsupported"); |
There was a problem hiding this comment.
The tests it borked otherwise due to an invalid SKIPIF section
| if (!function_exists("pg_set_chunked_rows_mode")) die("pg_set_chunked_rows_mode unsupported"); | |
| if (!function_exists("pg_set_chunked_rows_mode")) die("skip pg_set_chunked_rows_mode unsupported"); |
ext/pgsql/pgsql.c
Outdated
| /** can still fail if it is not allowed e.g. already fetched results **/ | ||
|
|
||
| RETURN_LONG((zend_long)PQsetChunkedRowsMode(link->conn, (int)size)); |
There was a problem hiding this comment.
What value is returned on failure? 0 ?
There was a problem hiding this comment.
yes. it might be more appropriate to return a bool then.
devnexen
force-pushed
the
pg_set_chunked_rows_mode
branch
from
ccb8fb8 to
c4e9aed
Compare
ext/pgsql/pgsql.c
Outdated
| @@ -6248,3 +6246,29 @@ PHP_FUNCTION(pg_socket_poll) | |||
|
|
|||
| RETURN_LONG((zend_long)PQsocketPoll(socket, (int)read, (int)write, (int)ts)); | |||
| } | |||
|
|
|||
| #if defined(HAVE_PG_SET_CHUNKED_ROWS_MODE) | |||
| PHP_FUNCTION(pg_set_chunked_rows_mode) | |||
There was a problem hiding this comment.
The name of the function confuses me, is this setting a "mode" or the number of rows to chunk?
There was a problem hiding this comment.
"mode" refers to chunk mode vs single row mode (which is another libpq call, thus the exposition of PGSQL_TUPLES_CHUNK constant to differentiate it) but yes it set the number of rows.
There was a problem hiding this comment.
Does it possibly make sense to name the function we expose to userland in a slightly more sensible way? I think just replacing mode with size would possibly do.
And thus it mean, it can only fail if trying to set up a chunk size for results that cannot be chunked?
pg_set_chunked_rows_mode to allow to fetch results in chunk of max N rows.
devnexen
force-pushed
the
pg_set_chunked_rows_mode
branch
from
c4e9aed to
99f8c2f
Compare
pg_set_chunked_rows_mode to allow to fetch results in chunk of max N rows.