Refactor: [pdo_firebird] unified function naming #12750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SakiTakamachi
force-pushed
the
pdo-firebird-unified-function-naming
branch
from
a1be606 to
a4a0df8
Compare
|
cc: @Girgias |
Girgias
approved these changes
Nov 22, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
struct pdo_dbh_methods=> Naming convention similar to other PDOsstruct pdo_stmt_methods=> Naming convention similar to other PDOsother func => add
php_firebird_prefix (Omitfirebirdfor some things that get too long)Also, there were still some parts where only the error code was set using
strcpy, so I fixed it.