Skip to content

See if this fixes Firbird parallel issues #12545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Oct 28, 2023

No description provided.

@SakiTakamachi
Copy link
Member

I was curious and took a look at this, but it's definitely not due to a conflict between tests. Even if I run the php file generated from phpt alone, a transaction error occurs.

It seems that the switching of dbh->in_txn is probably insufficient, and there are places where it remains true and does not return.

@Girgias
Copy link
Member Author

Girgias commented Nov 12, 2023

I was curious and took a look at this, but it's definitely not due to a conflict between tests. Even if I run the php file generated from phpt alone, a transaction error occurs.

It seems that the switching of dbh->in_txn is probably insufficient, and there are places where it remains true and does not return.

Thank you for investigating! So do you think this is a problem with the Firebird driver or with the test?

@SakiTakamachi
Copy link
Member

Thank you for investigating! So do you think this is a problem with the Firebird driver or with the test?

I believe it is an implementation issue of pdo_firebird. The test is perfectly fine and has told us about bugs in firebird.

I'm currently working on fixing this issue. I'll be able to submit a pull request in about an hour.

@SakiTakamachi
Copy link
Member

SakiTakamachi commented Nov 12, 2023

I got it working for now. I'll think of a better way to write it, and I'll add comments where they are needed.

#12657
#12741

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants