Skip to content

Fix GH-10914: OPCache with Enum and Callback functions results in segmentation fault #11675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix GH-10914: OPCache with Enum and Callback functions results in segmentation fault #11675

wants to merge 1 commit into from

Conversation

nielsdos
Copy link
Member

Closes GH-10914.

See linked issue for analysis.

@nielsdos
Fix phpGH-10914: OPCache with Enum and Callback functions results in …
e6abc93 
…segmentation fault

See linked issue for analysis.
iluuu1994
iluuu1994 approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@iluuu1994 iluuu1994 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think this should fail with opcache and an include, even without preloading? In that case we could test on Windows too.

@nielsdos
Copy link
Member Author

@iluuu1994 Thanks for reviewing. Just tried it with an include instead of via preloading and it doesn't trigger the bug.

@iluuu1994
Copy link
Member

Huh, ok. I'm hazy on the details, in that case this looks fine!

@nielsdos nielsdos closed this in bc42179 Jul 11, 2023
@iluuu1994 iluuu1994 mentioned this pull request Jul 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluuu1994 iluuu1994 iluuu1994 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsdos @iluuu1994