Add persistent functionality #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it would be better to always use persistent queues for AMQP\RabbitMQ transports. Something like this would be great: <?php
use Interop\Amqp\AmqpMessage;
if ($message instanceof AmqpMessage) {
$message->setDeliveryMode(AmqpMessage::DELIVERY_MODE_PERSISTENT);
} |
|
Updated, please check |
makasim
reviewed
Mar 29, 2018
src/Queue.php
Outdated
| @@ -56,9 +56,15 @@ public function push($job, $data = '', $queue = null) | |||
| */ | |||
| public function pushRaw($payload, $queue = null, array $options = []) | |||
| { | |||
| $message = $this->psrContext->createMessage($payload); | |||
|
|
|||
| if ($message instanceof \Interop\Amqp\Impl\AmqpMessage) { | |||
There was a problem hiding this comment.
For interface \Interop\Amqp\AmqpMessage or implementation Interop\Amqp\AmqpMessage?
We can't use both or I could use an alias. Which you prefer?
There was a problem hiding this comment.
use Interop\Amqp\AmqpMessage;
if ($message instanceof AmqpMessage) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RabbitMQ has persistent message functionality that has not been serviced.
To use it, just add to your app/Jobs/SomeJob.php field
$persistent = true. After that when you restart RabbitMQ message still be in a queue.