Skip to content

Update composer.json #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2020
Merged

Update composer.json #19

merged 2 commits into from
Oct 2, 2020

Conversation

lothid
Copy link
Contributor

@lothid lothid commented Oct 2, 2020

Support for Laravel 8.

@makasim
Copy link
Member

makasim commented Oct 2, 2020

Have you tested it with Laravel 8 ?

@lothid
Copy link
Contributor Author

lothid commented Oct 2, 2020

Yes, I am using it through my fork in Laravel 8 project (AMQP transport).
Everything seems to work alright.
Not sure what to do with failed continuous-integration check though.

@danilopolani
Copy link

I guess the error of Travis comes from the tests on PHPv5.6 that does not support return types (or Type Hinting at all? I don't quite remember). Imho in a major of this package PHP5.6 should be deprecated and requiring only PHP >= 7.3 (Like Laravel 8) could be an idea. Not sure about PHP 7.3 as constraint, but it should be at least 7.1 IMHO

@makasim
Copy link
Member

makasim commented Oct 2, 2020

Could you please remove tests for PHP5.x version and raise a constraint to 7.1 ?

@lothid
Copy link
Contributor Author

lothid commented Oct 2, 2020

Sure.
In composer.json constraint is already PHP 7.1 so I just modified Travis CI PHP versions.

@makasim makasim merged commit e19e883 into php-enqueue:master Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants