Skip to content

fixing pandas.DataFrame.plot(): labels do not appear in legend and label kwd #9574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2015
+21 −11
Merged

fixing pandas.DataFrame.plot(): labels do not appear in legend and label kwd #9574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions doc/source/whatsnew/v0.16.1.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ Performance Improvements
Bug Fixes
~~~~~~~~~

- Fixed bug (:issue:`9542`) where labels did not appear properly in legend of ``DataFrame.plot()``. Passing ``label=`` args also now works, and series indices are no longer mutated.




Expand Down
20 changes: 14 additions & 6 deletions pandas/tests/test_graphics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1064,12 +1064,6 @@ def test_implicit_label(self):
ax = df.plot(x='a', y='b')
self._check_text_labels(ax.xaxis.get_label(), 'a')

@slow
def test_explicit_label(self):
df = DataFrame(randn(10, 3), columns=['a', 'b', 'c'])
ax = df.plot(x='a', y='b', label='LABEL')
self._check_text_labels(ax.xaxis.get_label(), 'LABEL')

@slow
def test_donot_overwrite_index_name(self):
# GH 8494
Expand Down Expand Up @@ -2542,6 +2536,20 @@ def test_df_legend_labels(self):
ax = df3.plot(kind='scatter', x='g', y='h', label='data3', ax=ax)
self._check_legend_labels(ax, labels=['data1', 'data3'])

# ensure label args pass through and
# index name does not mutate
# column names don't mutate
df5 = df.set_index('a')
ax = df5.plot(y='b')
self._check_legend_labels(ax, labels=['b'])
ax = df5.plot(y='b', label='LABEL_b')
self._check_legend_labels(ax, labels=['LABEL_b'])
self._check_text_labels(ax.xaxis.get_label(), 'a')
ax = df5.plot(y='c', label='LABEL_c', ax=ax)
self._check_legend_labels(ax, labels=['LABEL_b','LABEL_c'])
self.assertTrue(df5.columns.tolist() == ['b','c'])


def test_legend_name(self):
multi = DataFrame(randn(4, 4),
columns=[np.array(['a', 'a', 'b', 'b']),
Expand Down
10 changes: 5 additions & 5 deletions pandas/tools/plotting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -886,10 +886,11 @@ def _iter_data(self, data=None, keep_index=False, fillna=None):

from pandas.core.frame import DataFrame
if isinstance(data, (Series, np.ndarray, Index)):
label = self.label if self.label is not None else data.name
if keep_index is True:
yield self.label, data
yield label, data
else:
yield self.label, np.asarray(data)
yield label, np.asarray(data)
elif isinstance(data, DataFrame):
if self.sort_columns:
columns = com._try_sort(data.columns)
Expand Down Expand Up @@ -2306,10 +2307,9 @@ def _plot(data, x=None, y=None, subplots=False,
if y is not None:
if com.is_integer(y) and not data.columns.holds_integer():
y = data.columns[y]
label = x if x is not None else data.index.name
label = kwds.pop('label', label)
label = kwds['label'] if 'label' in kwds else y
series = data[y].copy() # Don't modify
series.index.name = label
series.name = label

for kw in ['xerr', 'yerr']:
if (kw in kwds) and \
Expand Down