Skip to content

BUG: Fixed maximum columns limit when using usecols for csv. #8985 #9029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/source/whatsnew/v0.15.2.txt
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,7 @@ Bug Fixes
- Bug in ``merge`` where ``how='left'`` and ``sort=False`` would not preserve left frame order (:issue:`7331`)
- Fix: The font size was only set on x axis if vertical or the y axis if horizontal. (:issue:`8765`)
- Fixed division by 0 when reading big csv files in python 3 (:issue:`8621`)
- When using usecols csv reader only requires the minimum amount of columns instead of all (:issue:`8985`)



Expand Down
13 changes: 11 additions & 2 deletions pandas/io/parsers.py
Original file line number Diff line number Diff line change
Expand Up @@ -1918,9 +1918,17 @@ def _rows_to_cols(self, content):
# Loop through rows to verify lengths are correct.
if col_len != zip_len and self.index_col is not False:
i = 0
incorrect_row = False
if self.usecols:
col_len = max(self.usecols) + 1

for (i, l) in enumerate(content):
if len(l) != col_len:
break
if self.usecols and len(l) > col_len:
continue
else:
incorrect_row = True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need to use this variable incorrect_row, just raise right here (and and reverse the if condition)

e.g.

if not (self.usecols and len(l) > col_len):
    raise ValueError(.....)

break

footers = 0
if self.skip_footer:
Expand All @@ -1930,7 +1938,8 @@ def _rows_to_cols(self, content):

msg = ('Expected %d fields in line %d, saw %d' %
(col_len, row_num + 1, zip_len))
raise ValueError(msg)
if incorrect_row:
raise ValueError(msg)

if self.usecols:
if self._implicit_index:
Expand Down
17 changes: 17 additions & 0 deletions pandas/io/tests/test_parsers.py
Original file line number Diff line number Diff line change
Expand Up @@ -2090,6 +2090,23 @@ def test_parse_integers_above_fp_precision(self):

self.assertTrue(np.array_equal(result['Numbers'], expected['Numbers']))

def test_use_cols_minumum_fields_in_line(self):
# issue #8985
data = """
19,29,39
19,29,39
10,20,30,40"""
df = pd.read_csv(StringIO(data), engine='python',
header=None, usecols=list(range(3)))
self.assertEqual(len(df.columns), 3)

df = pd.read_csv(StringIO(data), engine='python',
header=None, usecols=list(range(2)))
self.assertEqual(len(df.columns), 2)

self.assertRaises(ValueError, self.read_csv, StringIO(data),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this ONLY for the python engine?

engine='python', usecols=list(range(4)), header=None)

def test_usecols_index_col_conflict(self):
# Issue 4201 Test that index_col as integer reflects usecols
data = """SecId,Time,Price,P2,P3
Expand Down