-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
BUG: Fixed maximum columns limit when using usecols for csv. #8985 #9029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2090,6 +2090,23 @@ def test_parse_integers_above_fp_precision(self): | |
|
||
self.assertTrue(np.array_equal(result['Numbers'], expected['Numbers'])) | ||
|
||
def test_use_cols_minumum_fields_in_line(self): | ||
# issue #8985 | ||
data = """ | ||
19,29,39 | ||
19,29,39 | ||
10,20,30,40""" | ||
df = pd.read_csv(StringIO(data), engine='python', | ||
header=None, usecols=list(range(3))) | ||
self.assertEqual(len(df.columns), 3) | ||
|
||
df = pd.read_csv(StringIO(data), engine='python', | ||
header=None, usecols=list(range(2))) | ||
self.assertEqual(len(df.columns), 2) | ||
|
||
self.assertRaises(ValueError, self.read_csv, StringIO(data), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. is this ONLY for the python engine? |
||
engine='python', usecols=list(range(4)), header=None) | ||
|
||
def test_usecols_index_col_conflict(self): | ||
# Issue 4201 Test that index_col as integer reflects usecols | ||
data = """SecId,Time,Price,P2,P3 | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you don't need to use this variable incorrect_row, just raise right here (and and reverse the if condition)
e.g.