-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
DOC: update docs on direct plotting with matplotlib (GH8614) #8655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: update docs on direct plotting with matplotlib (GH8614) #8655
Conversation
… array subclass (GH8614)
@jorisvandenbossche I wrote that documentation to reflect the changes in PR #6650 that I prepared for issue #6636. In short, pandas does register its own formatters (see https://github.com/pydata/pandas/blob/master/pandas/tseries/converter.py#L27), so this behavior is entirely part of pandas. The PR obtained a speed-up by replacing a call to matplotlib's It seems that the formatters registered by pandas are still correctly called:
So far I do not see any obvious cause for the new problems, but I'll dive deeper into this later on. |
Ah, yes, I was confusing the 'converter' (which are registered in the matplotlib But, two points:
|
@@ -1566,15 +1566,11 @@ customization is not (yet) supported by pandas. Series and DataFrame objects | |||
behave like arrays and can therefore be passed directly to matplotlib functions | |||
without explicit casts. | |||
|
|||
pandas also automatically registers formatters and locators that recognize date | |||
indices, thereby extending date and time support to practically all plot types | |||
available in matplotlib. Although this formatting does not provide the same |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"extending date and time support to practically all plot types available in matplotlib" -> @agijsberts but matplotlib by default has also a datetime converter?
https://github.com/matplotlib/matplotlib/blob/v1.4.2/lib/matplotlib/dates.py#L1380 We just overwrite it with ours?
@jorisvandenbossche Re. your points:
|
So our Simply doing @agijsberts Thanks a lot for shedding your light on this! |
@jorisvandenbossche I'm glad to help. And yes, |
OK, I will then close this PR as it is totally the wrong way :-) |
Closes #8614
to_pydatetime
as direct plotting with a DatetimeIndex does not work anymore (see Plotting of DatetimeIndex directly with matplotlib no longer gives datetime formatted axis (0.15) #8614)