BUG: Fix DataFrame constructor misclassification of array-like with 'name' attribute (#61443) #61451
+18
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…name' attribute Previously, any object with a .name attribute (like some vtkArray-like objects) was assumed to be a Series or Index, causing the constructor to misinterpret the input. This fix ensures we only apply the named-Index/Series logic when the input is actually an instance of ABCSeries or ABCIndex *and* has a non-None name. Closes pandas-dev#61443.
|
Note: One unrelated pre-commit check failed: One of the flagged lines includes: f" instead.",This has a space at the start of the string rather than the end of the previous one, which violates the Since this file wasn't touched in this PR and is unrelated to the fix, I’ve left it as-is. Let me know if you'd like me to patch it. |
rhshadrach
requested changes
May 18, 2025
| @@ -2780,6 +2780,18 @@ def test_construction_nan_value_timedelta64_dtype(self): | |||
| ) | |||
| tm.assert_frame_equal(result, expected) | |||
|
|
|||
| def test_dataframe_from_array_like_with_name_attribute(self): | |||
| class DummyArray(np.ndarray): | |||
There was a problem hiding this comment.
Can you start this test with a comment referring to the GitHub issue
# https://github.com/pandas-dev/pandas/issues/61443
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUG: Fix DataFrame constructor misclassification of array-like with 'name' attribute
Previously, any object with a
.nameattribute (like somevtkArray-like objects) was assumed to be aSeriesorIndex, causing the DataFrame constructor to misinterpret the input and raise errors when passed valid 2D array-likes.This fix ensures we only apply the named-Series/Index logic when the input is actually an instance of
ABCSeriesorABCIndex, and thenameis notNone.A new test was added to ensure array-like subclasses with
.nameare handled correctly.DataFrameconstructor not compatible with array-like classes that have a'name'attribute #61443pre-commit.namecase