BUG: to_numpy not respecting na_value before converting to array #50506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Jan 3, 2023
doc/source/whatsnew/v2.0.0.rst
Outdated
| @@ -775,6 +775,7 @@ Performance improvements | |||
| - Performance improvement when iterating over pyarrow and nullable dtypes (:issue:`49825`, :issue:`49851`) | |||
| - Performance improvements to :func:`read_sas` (:issue:`47403`, :issue:`47405`, :issue:`47656`, :issue:`48502`) | |||
| - Memory improvement in :meth:`RangeIndex.sort_values` (:issue:`48801`) | |||
| - Performance improvement in :meth:`Series.to_numpy` if ``copy=True`` but data was copied anyway (:issue:`24345`) | |||
There was a problem hiding this comment.
data was copied anyway is kinda confusing since I would expect copy=True to have made a copy of the data. Is this supposed to refer to the fact that the data is no longer copied twice?
There was a problem hiding this comment.
Not sure what I was thinking here, this makes no sense, your interpretation is correct. Will adjust accordingly
mroeschke
added
Missing-data
mroeschke
approved these changes
Jan 5, 2023
|
Thanks @phofl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.