Skip to content

Fix some dosctring RT02 error #50197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 13, 2022
Merged

Fix some dosctring RT02 error #50197

merged 4 commits into from
Dec 13, 2022

Conversation

luke396
Copy link
Contributor

@luke396 luke396 commented Dec 12, 2022 •
edited
Loading

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@luke396
Copy link
Contributor Author

luke396 commented Dec 12, 2022

About #49968

phofl
phofl reviewed Dec 12, 2022
View reviewed changes
@mroeschke mroeschke added the Docs label Dec 12, 2022
MarcoGorelli
MarcoGorelli approved these changes Dec 13, 2022
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, over to @phofl

@MarcoGorelli MarcoGorelli added this to the 2.0 milestone Dec 13, 2022
@MarcoGorelli MarcoGorelli added the Code Style Code style, linting, code_checks label Dec 13, 2022
@phofl phofl merged commit bce9958 into pandas-dev:main Dec 13, 2022
@phofl
Copy link
Member

phofl commented Dec 13, 2022

thx @luke396

ShisuiUzumaki added a commit to ShisuiUzumaki/pandas that referenced this pull request Dec 14, 2022
@ShisuiUzumaki
Revert "Fix some dosctring RT02 error (pandas-dev#50197)"
e56dfa7 
This reverts commit bce9958.
@luke396 luke396 deleted the dosctring-RT02-error branch December 15, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

@phofl phofl phofl approved these changes

Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks Docs
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@luke396 @phofl @MarcoGorelli @mroeschke