Skip to content

API: make FloatingArray.astype consistent with IntegerArray/BooleanArray #50028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2022
Merged

API: make FloatingArray.astype consistent with IntegerArray/BooleanArray #50028

merged 1 commit into from
Dec 5, 2022

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@topper-123 topper-123 added this to the 2.0 milestone Dec 3, 2022
@topper-123 topper-123 added Dtype Conversions Unexpected or buggy dtype conversions NA - MaskedArrays Related to pd.NA and nullable extension arrays labels Dec 3, 2022
topper-123
topper-123 approved these changes Dec 3, 2022
View reviewed changes
Copy link
Contributor

@topper-123 topper-123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@phofl phofl merged commit 0ca49fc into pandas-dev:main Dec 5, 2022
@phofl
Copy link
Member

phofl commented Dec 5, 2022

thx @jbrockmendel

@jbrockmendel jbrockmendel deleted the api-astype-masked branch December 5, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phofl phofl phofl left review comments

@topper-123 topper-123 topper-123 approved these changes

Assignees
No one assigned
Labels
Astype Dtype Conversions Unexpected or buggy dtype conversions NA - MaskedArrays Related to pd.NA and nullable extension arrays
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @phofl @topper-123