Skip to content

BUG: Series.map is ignoring the na_action keyword #46860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Apr 27, 2022
Merged

BUG: Series.map is ignoring the na_action keyword #46860

merged 15 commits into from
Apr 27, 2022

Conversation

stanleycai95
Copy link
Contributor

@stanleycai95 stanleycai95 commented Apr 24, 2022 •
edited
Loading

mroeschke
mroeschke reviewed Apr 24, 2022
View reviewed changes
mroeschke
mroeschke requested changes Apr 24, 2022
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also good to have a whatsnew entry in 1.5.0.rst (probably in the Other Enhancement section as a improvement in error reporting)

@pep8speaks
Copy link

pep8speaks commented Apr 24, 2022 •
edited
Loading

Hello @stanleycai95! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-04-26 01:48:01 UTC

@stanleycai95
Copy link
Contributor Author

Added documentation updates + test. Thank you for the feedback!!

@stanleycai95 stanleycai95 changed the title Series.map is ignoring the na_action keyword BUG: Series.map is ignoring the na_action keyword Apr 25, 2022
mroeschke
mroeschke reviewed Apr 25, 2022
View reviewed changes
@rhshadrach rhshadrach added Bug Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate labels Apr 25, 2022
jreback
jreback requested changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment, pls merge master and ping on green

@jreback jreback added this to the 1.5 milestone Apr 26, 2022
stanleycai95
stanleycai95 commented Apr 26, 2022
View reviewed changes
Copy link
Contributor Author

@stanleycai95 stanleycai95 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!! Made corresponding changes.

@jreback jreback merged commit 4eb4be2 into pandas-dev:main Apr 27, 2022
@jreback
Copy link
Contributor

jreback commented Apr 27, 2022

thanks @stanleycai95 very nice!

yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@stanleycai95 @yehoshuadimarsky
BUG: Series.map is ignoring the na_action keyword (pandas-dev#46860)
f8b5bb2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Bug Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

BUG: Series.map is ignoring the na_action keyword
5 participants
@stanleycai95 @pep8speaks @jreback @mroeschke @rhshadrach