Skip to content

CLN: FIXMEs #44771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 6, 2021
Merged

CLN: FIXMEs #44771

merged 3 commits into from
Dec 6, 2021

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx
  • tests added / passed
  • Ensure all linting tests pass, see here for how to run them
  • whatsnew entry

# ---------------------------------------------------------------------
# AMBIGUOUS CASES!

def test_partial_loc_missing(self, multiindex_year_month_day_dataframe_random_data):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not me, hahaha

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im proud of tracking this one down!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heheh no doubt!

@jreback jreback added Clean Testing pandas testing functions or related to the test suite labels Dec 5, 2021
@jreback jreback added this to the 1.4 milestone Dec 5, 2021
@jbrockmendel
Copy link
Member Author

CI fail is from the lint issue fixed on master a little while ago

@jreback jreback merged commit 097322f into pandas-dev:master Dec 6, 2021
@jbrockmendel jbrockmendel deleted the fixmes18 branch December 6, 2021 05:54
@jbrockmendel
Copy link
Member Author

One that i'll need some help figuring out how to make actionable: https://github.com/pandas-dev/pandas/blob/master/pandas/plotting/_matplotlib/timeseries.py#L231

bonsoirval added a commit to bonsoirval/pandas that referenced this pull request Dec 20, 2021
MarcoGorelli pushed a commit that referenced this pull request Dec 20, 2021
* Updated config.py and fix a typo

* Updating git commit message to standard

* DOC: Additions/updates to documentation #44771
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants