-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
CLN: FIXMEs #44771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLN: FIXMEs #44771
Conversation
jbrockmendel
commented
Dec 5, 2021
- closes #xxxx
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
# --------------------------------------------------------------------- | ||
# AMBIGUOUS CASES! | ||
|
||
def test_partial_loc_missing(self, multiindex_year_month_day_dataframe_random_data): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was original an 'ix' test 10 years ago, never got enabled. https://github.com/pandas-dev/pandas/blame/1f00335b51d345d58e9574c2c5d86613214aba9b/pandas/tests/test_multilevel.py#L1421
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not me, hahaha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im proud of tracking this one down!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
heheh no doubt!
CI fail is from the lint issue fixed on master a little while ago |
One that i'll need some help figuring out how to make actionable: https://github.com/pandas-dev/pandas/blob/master/pandas/plotting/_matplotlib/timeseries.py#L231 |
* Updated config.py and fix a typo * Updating git commit message to standard * DOC: Additions/updates to documentation #44771