-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
TYP: use __all__ to signal public API to type checkers #43695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
2983bf5
TYP: redundant imports for public API
twoertwein 01818da
typo
twoertwein 1bc208a
use __all__
twoertwein 31bdcd3
sort
twoertwein 44a905e
added missing modules and added a test
twoertwein e0d896c
remove core, io, ...
twoertwein dc7ee31
add public modules based on documentation
twoertwein f127eb6
io and tseries: recursively add documented to be public modules to __…
twoertwein e5c766b
remove deprecated functions from __all__
twoertwein c953389
dont reformat init
twoertwein File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
from typing import TYPE_CHECKING | ||
|
||
if TYPE_CHECKING: | ||
# import modules that have public classes/functions | ||
from pandas.io import ( | ||
formats, | ||
json, | ||
stata, | ||
) | ||
|
||
# and mark only those modules as public | ||
__all__ = ["formats", "json", "stata"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
from typing import TYPE_CHECKING | ||
|
||
if TYPE_CHECKING: | ||
# import modules that have public classes/functions | ||
from pandas.io.formats import style | ||
|
||
# and mark only those modules as public | ||
__all__ = ["style"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,21 +30,18 @@ class TestPDApi(Base): | |
ignored = ["tests", "locale", "conftest"] | ||
|
||
# top-level sub-packages | ||
lib = [ | ||
public_lib = [ | ||
"api", | ||
"arrays", | ||
"compat", | ||
"core", | ||
"errors", | ||
"pandas", | ||
"plotting", | ||
"options", | ||
"test", | ||
"testing", | ||
"tseries", | ||
"util", | ||
"options", | ||
"errors", | ||
"plotting", | ||
"io", | ||
"tseries", | ||
] | ||
private_lib = ["compat", "core", "pandas", "util"] | ||
|
||
# these are already deprecated; awaiting removal | ||
deprecated_modules: list[str] = ["np", "datetime"] | ||
|
@@ -204,7 +201,8 @@ class TestPDApi(Base): | |
def test_api(self): | ||
|
||
checkthese = ( | ||
self.lib | ||
self.public_lib | ||
+ self.private_lib | ||
+ self.misc | ||
+ self.modules | ||
+ self.classes | ||
|
@@ -217,6 +215,26 @@ def test_api(self): | |
) | ||
self.check(namespace=pd, expected=checkthese, ignored=self.ignored) | ||
|
||
def test_api_all(self): | ||
expected = set( | ||
self.public_lib | ||
+ self.misc | ||
+ self.modules | ||
+ self.classes | ||
+ self.funcs | ||
+ self.funcs_option | ||
+ self.funcs_read | ||
+ self.funcs_json | ||
+ self.funcs_to | ||
) - set(self.deprecated_classes) | ||
actual = set(pd.__all__) | ||
|
||
extraneous = actual - expected | ||
assert not extraneous | ||
|
||
missing = expected - actual | ||
assert not missing | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
|
||
def test_depr(self): | ||
deprecated_list = ( | ||
self.deprecated_modules | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
from typing import TYPE_CHECKING | ||
|
||
if TYPE_CHECKING: | ||
# import modules that have public classes/functions: | ||
from pandas.tseries import ( | ||
frequencies, | ||
offsets, | ||
) | ||
|
||
# and mark only those modules as public | ||
__all__ = ["frequencies", "offsets"] |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.