Fix frame_or_series.asfreq() dropping rows on unordered indices #40384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
requested changes
Mar 15, 2021
|
also pls add a whatsnew note, 1.3. bug fixes, resample section |
|
@jreback Look good? |
jreback
requested changes
Mar 21, 2021
|
@jreback I just changed the test to resemble the previous test in format. Hopefully, that makes its intention more clear? |
jreback
requested changes
Mar 22, 2021
| expected = result.copy().reindex(sorted(index)) | ||
|
|
||
| result = result.asfreq("D") | ||
| expected = expected.asfreq("D") |
There was a problem hiding this comment.
right after L101, do this instead
expected.index = expected.index._with_freq('D')
There was a problem hiding this comment.
I couldn't use ._with_freq('D'); it failed with an assertion error because it expects None or 'infer'.
I used infer.
jreback
approved these changes
Mar 23, 2021
|
thanks @nmay231 |
vladu
pushed a commit
to vladu/pandas
that referenced
this pull request
Apr 5, 2021
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asfreqsilently drops rows when index is not sorted #39805This prevents
frame_or_series.asfreq()from dropping rows/items if the index is not sorted.This seemed like a relatively easy fix, and it should probably be done sooner than later. However, there wasn't much discussion in the issue so I still have some questions:
a. Silently "sort" the index before reindexing. Or we could
b. Raise a warning before "sorting." Or
c. Raise an error.
asfreqtests from class-based to functions. Can I do that in this PR or should I do that in another one?