TST/CLN: deduplicate troublesome rank values #38894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzeitlin11
added
Testing
jreback
requested changes
Jan 3, 2021
pandas/conftest.py
Outdated
| @@ -591,6 +593,91 @@ def narrow_series(request): | |||
| return _narrow_series[request.param].copy() | |||
|
|
|||
|
|
|||
| _dtype_nuisance_arr_map = { | |||
There was a problem hiding this comment.
can you add a comment here about where this is used
pandas/conftest.py
Outdated
| "object": [NegInfinity(), "1", "A", "BA", "Ba", "C", Infinity()], | ||
| } | ||
|
|
||
| _dtype_na_map = { |
There was a problem hiding this comment.
can you put this inside the fixture, this is generally a special case
pandas/conftest.py
Outdated
| @@ -591,6 +593,91 @@ def narrow_series(request): | |||
| return _narrow_series[request.param].copy() | |||
|
|
|||
|
|
|||
| _dtype_nuisance_arr_map = { | |||
jreback
requested changes
Jan 3, 2021
| iranks = iseries.rank() | ||
| tm.assert_series_equal(iranks, exp) | ||
| def test_rank_inf(self, nuisance_rank_series_and_expected): | ||
| series, expected = nuisance_rank_series_and_expected |
There was a problem hiding this comment.
actually an alternative here is simply to use frame_or_series fixture and leave the fixture in tests/frame/methods (e.g. this is what we do for things for both series & frame), i think in this case it makes more sense.
There was a problem hiding this comment.
yah i think this makes a lot more sense than a relatively-complicated fixture in conftest
There was a problem hiding this comment.
Thanks that is much nicer, good pattern to know
jreback
approved these changes
Jan 3, 2021
|
perfect, ping on green |
|
green |
|
thanks |
luckyvs1
pushed a commit
to luckyvs1/pandas
that referenced
this pull request
Jan 20, 2021
* WIP * TST/CLN: deduplicate troublesome rank values * Remove unneeded imports * Address comments * Use frame_or_series instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #38681 (comment)