-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Updated PULL_REQUEST_TEMPLATE.md #38696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
5761c9c
Updated PULL_REQUEST_TEMPLATE.md
BobinMathew 797b2ba
Merge pull request #1 from pandas-dev/master
BobinMathew c3f0487
Added issue number
BobinMathew 13cb90e
Change reverted
BobinMathew b2277ff
Added link to docs
BobinMathew df66eab
Removed unwanted spaces
BobinMathew 6ab2f1f
Merge pull request #2 from pandas-dev/master
BobinMathew 3f7fd67
Modified code standards section
BobinMathew d52c4f4
Reverted one checkbox
BobinMathew 9b5ed55
Removed ``
BobinMathew 93a6ca6
Reverted to 'closes #xxxx'
BobinMathew 23836d2
Removed one "pass" check
BobinMathew 23e20f9
Update contributing.rst
BobinMathew 222c612
Update contributing.rst
BobinMathew e6c716b
Reverted contributing.rst
BobinMathew File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,4 @@ | ||
- [ ] closes #xxxx | ||
- [ ] tests added / passed | ||
- [ ] passes `black pandas` | ||
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff` | ||
- [ ] Ensure all linting tests pass, see [here](https://pandas.pydata.org/pandas-docs/dev/development/contributing.html#code-standards) for how to run them | ||
- [ ] whatsnew entry |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.