DOC: Move API breaking to appropriate sections #34865
Conversation
| @@ -623,57 +532,14 @@ The method :meth:`core.DataFrameGroupBy.size` would previously ignore ``as_index | |||
|
|
|||
| df.groupby("a", as_index=False).size() | |||
|
|
|||
| .. _whatsnew_110.api_breaking.apply_applymap_first_once: | |||
There was a problem hiding this comment.
| @@ -524,39 +466,6 @@ those integer keys is not present in the first level of the index (:issue:`33539 | |||
|
|
|||
| left_df.merge(right_df, on=['animal', 'max_speed'], how="right") | |||
|
|
|||
| .. --------------------------------------------------------------------------- | |||
There was a problem hiding this comment.
| @@ -336,68 +340,6 @@ Other enhancements | |||
| Backwards incompatible API changes | |||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | |||
|
|
|||
| ``MultiIndex.get_indexer`` interprets `method` argument differently | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
I would rather not move this, this example is very needed to understand what the heck that change was.
I have no problem with you moving things around, but let's leave the examples. If you want to remove them, then let's discuss individually.
| @@ -524,39 +466,6 @@ those integer keys is not present in the first level of the index (:issue:`33539 | |||
|
|
|||
| left_df.merge(right_df, on=['animal', 'max_speed'], how="right") | |||
|
|
|||
| .. --------------------------------------------------------------------------- | |||
There was a problem hiding this comment.
| @@ -623,57 +532,14 @@ The method :meth:`core.DataFrameGroupBy.size` would previously ignore ``as_index | |||
|
|
|||
| df.groupby("a", as_index=False).size() | |||
|
|
|||
| .. _whatsnew_110.api_breaking.apply_applymap_first_once: | |||
There was a problem hiding this comment.
|
Also cc @jorisvandenbossche for confirmation that this all look like bug fixes. |
| @@ -336,68 +340,6 @@ Other enhancements | |||
| Backwards incompatible API changes | |||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | |||
|
|
|||
| ``MultiIndex.get_indexer`` interprets `method` argument differently | |||
There was a problem hiding this comment.
I would rather not move this, this example is very needed to understand what the heck that change was.
I have no problem with you moving things around, but let's leave the examples. If you want to remove them, then let's discuss individually.
|
I need to close this for a while. |
As discussed in #34801, this moves some items from our "API breaking changes" section to either bug fixes or enhancements. I've only moved the ones we can hopefully get consensus on as bug fix / enhancement. But let me know if any of these need further discussion on whether they're an API breaking change.