Skip to content

REF: _convert_to_index_sliceable as DataFrame method #33488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

jbrockmendel
Copy link
Member

It really doesnt make sense as anything other than a method.

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1 on moving things to frame.py this is purely an indexing method and surely belongs as a method on index itself if anything.

@jbrockmendel
Copy link
Member Author

belongs as a method on index itself if anything.

It's specifically DataFrame-only behavior. I'd like to deprecate it (#31476), but failing that this is effectively a function with self as the first arg, which is an antipattern.

@jbrockmendel jbrockmendel added the Refactor Internal refactoring of code label Apr 13, 2020
@jbrockmendel
Copy link
Member Author

mothballing to clear the queue

@jbrockmendel jbrockmendel added the Mothballed Temporarily-closed PR the author plans to return to label Apr 21, 2020
@jbrockmendel jbrockmendel deleted the frame-indexing branch July 16, 2021 16:08
@jbrockmendel jbrockmendel removed the Mothballed Temporarily-closed PR the author plans to return to label Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Internal refactoring of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants