Skip to content

BUG: Fix DataFrame.apply(..., raw=True) not calling with raw array #32425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 14, 2020
Merged

BUG: Fix DataFrame.apply(..., raw=True) not calling with raw array #32425

merged 4 commits into from
Mar 14, 2020

Conversation

kernc
Copy link
Contributor

@kernc kernc commented Mar 3, 2020 •
edited
Loading

@kernc
Copy link
Contributor Author

kernc commented Mar 4, 2020

Seems to pass. 🎉 Where do I put the whatsnew?

WillAyd
WillAyd requested changes Mar 4, 2020
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Can you put the whatsnew note in for 1.1?

@jreback

@WillAyd WillAyd added the Window rolling, ewma, expanding label Mar 4, 2020
@mroeschke mroeschke added Apply Apply, Aggregate, Transform, Map and removed Window rolling, ewma, expanding labels Mar 4, 2020
jreback
jreback requested changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. can you add a whatsnew note for 1.1, in bug fixes, reshaping.

jreback
jreback requested changes Mar 4, 2020
View reviewed changes
WillAyd
WillAyd approved these changes Mar 6, 2020
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm @jreback

@WillAyd WillAyd added this to the 1.1 milestone Mar 6, 2020
@kernc kernc requested a review from jreback March 12, 2020 21:08
@jreback jreback merged commit 1a5b11d into pandas-dev:master Mar 14, 2020
@jreback
Copy link
Contributor

jreback commented Mar 14, 2020

thanks @kernc

@simonjayhawkins simonjayhawkins mentioned this pull request Mar 16, 2020
Closed
SeeminSyed pushed a commit to CSCD01-team01/pandas that referenced this pull request Mar 22, 2020
@kernc @SeeminSyed
BUG: Fix DataFrame.apply(..., raw=True) not calling with raw array (p…
f212352 
…andas-dev#32425)
@victor-ab victor-ab mentioned this pull request Apr 10, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Apply Apply, Aggregate, Transform, Map Bug
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
5 participants
@kernc @jreback @WillAyd @mroeschke @simonjayhawkins