BUG: reductions for nullable dtypes should return pd.NA for skipna=False #30971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
added
Bug
Missing-data
jreback
approved these changes
Jan 14, 2020
jorisvandenbossche
changed the title
|
We have a section for NA-related API breaking changes to IntegerArray that this can fall under. |
TomAugspurger
approved these changes
Jan 17, 2020
|
sure |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jan 18, 2020
…uld return pd.NA for skipna=False
jreback
pushed a commit
that referenced
this pull request
Jan 18, 2020
… pd.NA for skipna=False (#31121) Co-authored-by: Joris Van den Bossche <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #30958
Just realized that I should probably check boolean dtype as well