Skip to content

improve test for timestamp addition/subtraction #27192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 3, 2019
Merged

improve test for timestamp addition/subtraction #27192

merged 3 commits into from
Jul 3, 2019

Conversation

lostella
Copy link
Contributor

@lostella lostella commented Jul 2, 2019

This PR adds regression test cases for the addition/subtraction of time deltas to timestamps. In fact, this is causing issues in 0.24.2 when freq="M" and freq="W", and the problem is solved in master.

@jreback jreback added the Testing pandas testing functions or related to the test suite label Jul 3, 2019
@jreback jreback added this to the 0.25.0 milestone Jul 3, 2019
@jreback jreback added the Frequency DateOffsets label Jul 3, 2019
@lostella lostella force-pushed the improve-test-ts-addition branch from 5a0766c to 192eee6 Compare July 3, 2019 11:45
jreback
jreback approved these changes Jul 3, 2019
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. ping on green.

@jreback jreback merged commit f5038de into pandas-dev:master Jul 3, 2019
@jreback
Copy link
Contributor

jreback commented Jul 3, 2019

thanks @lostella

@lostella lostella deleted the improve-test-ts-addition branch July 3, 2019 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback approved these changes

Assignees
No one assigned
Labels
Frequency DateOffsets Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.

Adding offset to Timestamp discards freq information when freq="M" or "W"
2 participants
@lostella @jreback