Skip to content

Deprecated Series.ftype, Series.ftypes and DataFrame.ftypes features #26751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Conversation

thiviyanT
Copy link
Contributor

Deprecation of Series.ftype, Series.ftypes and DataFrame.ftypes
closes #26705

  • Updated the docstrings for the sphinx documentation
  • Updated the unit tests for testing deprecation warnings
  • Added Git Issue Number to unit tests

@codecov
Copy link

codecov bot commented Jun 9, 2019

Codecov Report

Merging #26751 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #26751      +/-   ##
==========================================
- Coverage    91.7%   91.69%   -0.01%     
==========================================
  Files         179      179              
  Lines       50767    50770       +3     
==========================================
- Hits        46555    46554       -1     
- Misses       4212     4216       +4
Flag Coverage Δ
#multiple 90.29% <100%> (ø) ⬆️
#single 41.2% <0%> (-0.09%) ⬇️
Impacted Files Coverage Δ
pandas/core/series.py 93.62% <100%> (+0.01%) ⬆️
pandas/core/generic.py 93.64% <100%> (ø) ⬆️
pandas/io/gbq.py 78.94% <0%> (-10.53%) ⬇️
pandas/core/frame.py 96.88% <0%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7748ca...2c80a30. Read the comment docs.

@thiviyanT
Copy link
Contributor Author

thiviyanT commented Jun 9, 2019

I can see that the builds are failing. Upon having a close look at the build logs, I can see that these failures are coming from the following test functions:

  • test_empty_frame_dtypes_ftypes (pandas/tests/frame/test_dtypes.py)
  • test_concat_empty_series_dtypes (pandas/tests/series/test_combine_concat.py)
  • test_construct_DataFrame_with_sp_series (pandas/tests/sparse/series/test_series.py)

Do you want me to update those unit tests as well?

@jreback
Copy link
Contributor

jreback commented Jun 9, 2019

there is no need to create a new PR for changes; just push to the old one

since it’s already done it’s ok

@thiviyanT thiviyanT closed this Jun 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate Series.ftype / DataFrame.ftypes
3 participants