#23648 - Validate docstring now checks for existence of docstring first. #23668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TST - validate_one() will check if docstring exists before performing other checks. If it does not exist, then a single error will be returned reading 'Docstring does not exist' PERF - validate_one will skip other validation checks if docstring doesn't exist, which will save time in cases of high volumes of function checks without docstrings.
|
Hello @iway1! Thanks for updating the PR.
Comment last updated on November 13, 2018 at 21:14 Hours UTC |
4 tasks
|
Closing this as duplicate of #23673 for now, see discussion in: #23673 (comment) @iway1 next time check in the GitHub comments if someone else is working on an issue, to avoid repetitive work. If you and @avolkov prefer to continue the work in this PR, please reopen here, and close the other PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TST - validate_one() will check if docstring exists before performing other checks. If it does not exist, then a single error will be returned reading 'Docstring does not exist'
PERF - validate_one will skip other validation checks if docstring doesn't exist, which will save time in cases of high volumes of function checks without docstrings.
python3 ./scripts/validate_docstrings.py --prefix=pandas.Series.imag