-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Docs readme update #23097
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs readme update #23097
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Do you also want to update the README to account for the non-functional python make.py build
line?
@@ -108,8 +108,9 @@ the pandas code and git, see `the developer pages | |||
When you start to work on some docs, be sure to update your code to the latest | |||
development version ('master'):: | |||
|
|||
git remote add upstream https://github.com/pandas-dev/pandas.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is really something that only ever needs to be done once would be better separated out
This all seems duplicative of the contributing page. How about we extract what isn't in there already and just change |
Codecov Report
@@ Coverage Diff @@
## master #23097 +/- ##
=======================================
Coverage 92.2% 92.2%
=======================================
Files 169 169
Lines 50924 50924
=======================================
Hits 46952 46952
Misses 3972 3972
Continue to review full report at Codecov.
|
+1 on what @TomAugspurger says. I personally wouldn't even bother on having a |
I suggested a link to the contributing docs to not break links, but I
assume people don't expect URLs pointing inside the tree of a git repo to
be around forever.
…On Fri, Oct 12, 2018 at 4:27 PM Marc Garcia ***@***.***> wrote:
+1 on what @TomAugspurger <https://github.com/TomAugspurger> says. I
personally wouldn't even bother on having a README in docs/, but if we
have one, I'd just link to the contributing page.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23097 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQHIsmIA2o0SnyH_uXXkCT9NBMBDiJyks5ukQk9gaJpZM4XYgsG>
.
|
@alexander-l-stone can you update to @TomAugspurger suggestion. |
Closing as stale. @alexander-l-stone if you want to continue working on it, please reopen or create a new PR, and refer to #23828. |
git diff upstream/master -u -- "*.py" | flake8 --diff