TST: Use multiple instances of parametrize instead of product in tests #21602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschendel
added
Testing
jschendel
commented
Jun 23, 2018
| [[1. / 3, 1., 1.], | ||
| [2. / 3, 1. / 3, 2. / 3], | ||
| [3. / 3, 2. / 3, 1. / 3]])]) | ||
| def test_rank_pct_true(method, exp): |
There was a problem hiding this comment.
This test was the only one in that was outside the class, which seemed a bit strange, so I moved it inside the class.
jreback
approved these changes
Jun 23, 2018
| @@ -8,7 +8,6 @@ | |||
| import numpy as np | |||
| from pandas import DataFrame, Series, compat, date_range, Index, MultiIndex | |||
| from pandas.util import testing as tm | |||
| from pandas.compat import lrange, product | |||
|
|
|||
| AGG_FUNCTIONS = ['sum', 'prod', 'min', 'max', 'median', 'mean', 'skew', | |||
| 'mad', 'std', 'var', 'sem'] | |||
There was a problem hiding this comment.
this should be a fixture (future PR)
jschendel
force-pushed
the
param-misc-tests
branch
from
73b58a2 to
35596c6
Compare
Codecov Report
@@ Coverage Diff @@
## master #21602 +/- ##
=======================================
Coverage 91.9% 91.9%
=======================================
Files 153 153
Lines 49548 49548
=======================================
Hits 45538 45538
Misses 4010 4010
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
productbeing used inside a@pytest.mark.parametrizehave been converted to separate instances of@pytest.mark.parametrizeproductfrom within tests where it was straightforwardproductbeing used within tests for looping purporses